src/parsing/scanner.h - Issue 1939173002: Fix Scanner::PushBack for surrogate code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/scanner.h

Issue 1939173002: Fix Scanner::PushBack for surrogate code points. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/scanner.h

diff --git a/src/parsing/scanner.h b/src/parsing/scanner.h

index 0bb18679c525aea7154dbbb687494e366b923511..b4c6b62d1488f5654869ca4e9bfedd2c03f79f1f 100644

--- a/src/parsing/scanner.h

+++ b/src/parsing/scanner.h

@@ -588,7 +588,7 @@ class Scanner {

}

void PushBack(uc32 ch) {

- if (ch > static_cast<uc32>(unibrow::Utf16::kMaxNonSurrogateCharCode)) {

+ if (c0_ > static_cast<uc32>(unibrow::Utf16::kMaxNonSurrogateCharCode)) {

source_->PushBack(unibrow::Utf16::TrailSurrogate(c0_));

source_->PushBack(unibrow::Utf16::LeadSurrogate(c0_));

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »