LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html - Issue 19390002: Spanning logical height is not added properly in all spanning rows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

Issue 19390002: Spanning logical height is not added properly in all spanning rows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@RowSpan_B254914_6

Patch Set: Review comments addressed Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

diff --git a/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html b/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

index d1ff10d3ad224fc731b7a5bde3fc36791ed499d7..4fb0ee564dfda918187acbebf621e09e933765a8 100644

--- a/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

+++ b/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

@@ -237,16 +237,16 @@

</tr>

- <tr data-expected-height="19">

+ <tr data-expected-height="37">

</tr>

- <tr data-expected-height="19">

+ <tr data-expected-height="38">

</tr>

- <tr data-expected-height="19">

+ <tr data-expected-height="49">

</tr>

- <tr data-expected-height="19">

+ <tr data-expected-height="49">

</tr>

</table>