LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html - Issue 19390002: Spanning logical height is not added properly in all spanning rows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1.html

Issue 19390002: Spanning logical height is not added properly in all spanning rows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@RowSpan_B254914_6

Patch Set: Review comments addressed Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2.html » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Table rowspan</title>	4 <title>Table rowspan</title>

5 <script src="../../resources/check-layout.js"></script>	5 <script src="../../resources/check-layout.js"></script>

6 <style>	6 <style>

7 td { font: 15px/1 Ahem }	7 td { font: 15px/1 Ahem }

8 #div-table { display: table; border-spacing: 2px }	8 #div-table { display: table; border-spacing: 2px }

9 #div-row, #span-row { display: table-row }	9 #div-row, #span-row { display: table-row }

10 #div-cell, #span-cell { display: table-cell }	10 #div-cell, #span-cell { display: table-cell }

(...skipping 219 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
230 </tr>	230 </tr>

231 <tr data-expected-height="19">	231 <tr data-expected-height="19">

232 <td>row5 col0</td>	232 <td>row5 col0</td>

233 <td>row5 col1</td>	233 <td>row5 col1</td>

234 <td>row5 col2</td>	234 <td>row5 col2</td>

235 </tr>	235 </tr>

236 <tr data-expected-height="0">	236 <tr data-expected-height="0">

237 <td rowspan=5 style="height:200px">row6 col0</td>	237 <td rowspan=5 style="height:200px">row6 col0</td>

238 <td rowspan=5 style="height:100px">row6 col1</td>	238 <td rowspan=5 style="height:100px">row6 col1</td>

239 </tr>	239 </tr>

240 <tr data-expected-height="19">	240 <tr data-expected-height="37">

241 <td>row7 col1</td>	241 <td>row7 col1</td>

242 </tr>	242 </tr>

243 <tr data-expected-height="19">	243 <tr data-expected-height="38">

244 <td>row8 col1</td>	244 <td>row8 col1</td>

245 </tr>	245 </tr>

246 <tr data-expected-height="19">	246 <tr data-expected-height="49">

247 <td>row9 col1</td>	247 <td>row9 col1</td>

248 </tr>	248 </tr>

249 <tr data-expected-height="19">	249 <tr data-expected-height="49">

250 <td>row10 col1</td>	250 <td>row10 col1</td>

251 </tr>	251 </tr>

252 </table>	252 </table>

253 </body>	253 </body>

254 </html>	254 </html>

OLD	NEW