Use v8::Object::CreateDataProperty() for object construction

Use v8::Object::CreateDataProperty() for object construction

When creating objects (and arrays) internally, we should typically use
CreateDataProperty() rather than Set(), since the latter may invoke
setters defined by scripts. This could potentially be used by exploits to
do evil things, but more likely is just a potential source of breakage
and/or confusion.

Also, it is typically non-conforming in the cases where exact behavior is
defined in a specification.

BUG=

Committed: https://crrev.com/c64e8e4ab82fa3a477ce6e238d9966023d62a6b3
Cr-Commit-Position: refs/heads/master@{#390924}

[Jens Widell, 2016-05-02 10:18:27]

jl@opera.com changed reviewers:
+ haraken@chromium.org

[Jens Widell, 2016-05-02 10:18:28]

PTAL

[haraken, 2016-05-02 10:52:51]

LGTM

[Jens Widell, 2016-05-02 11:20:23]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2016-05-02 11:20:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938943002/1

[commit-bot: I haz the power, 2016-05-02 12:29:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-02 12:30:39]

Description was changed from

==========
Use v8::Object::CreateDataProperty() for object construction

When creating objects (and arrays) internally, we should typically use
CreateDataProperty() rather than Set(), since the latter may invoke
setters defined by scripts. This could potentially be used by exploits to
do evil things, but more likely is just a potential source of breakage
and/or confusion.

Also, it is typically non-conforming in the cases where exact behavior is
defined in a specification.

BUG=
==========

to

==========
Use v8::Object::CreateDataProperty() for object construction

When creating objects (and arrays) internally, we should typically use
CreateDataProperty() rather than Set(), since the latter may invoke
setters defined by scripts. This could potentially be used by exploits to
do evil things, but more likely is just a potential source of breakage
and/or confusion.

Also, it is typically non-conforming in the cases where exact behavior is
defined in a specification.

BUG=

Committed: https://crrev.com/c64e8e4ab82fa3a477ce6e238d9966023d62a6b3
Cr-Commit-Position: refs/heads/master@{#390924}
==========

[commit-bot: I haz the power, 2016-05-02 12:30:40]

Patchset 1 (id:??) landed as
https://crrev.com/c64e8e4ab82fa3a477ce6e238d9966023d62a6b3
Cr-Commit-Position: refs/heads/master@{#390924}