third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp - Issue 1938943002: Use v8::Object::CreateDataProperty() for object construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp

Issue 1938943002: Use v8::Object::CreateDataProperty() for object construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp

index cbfff366342a018a0e4fd0ee8d8f33d5b88ed74e..35322d3ef63b79e4ac2a61ae8e8e7abb60cd89fe 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp

@@ -127,8 +127,10 @@ private:

return;

v8::Local<v8::Array> values = v8::Array::New(value.isolate(), m_values.size());

- for (size_t i = 0; i < m_values.size(); ++i)

- values->Set(i, m_values[i].v8Value());

+ for (size_t i = 0; i < m_values.size(); ++i) {

+ if (!v8CallBoolean(values->CreateDataProperty(value.context(), i, m_values[i].v8Value())))

+ return;

+ }

markPromiseSettled();

m_resolver.resolve(values);