More thorough tests for PaymentDetails

More thorough tests for PaymentDetails

- Tests for missing "amount" in a line item or a shipping option.

- Tests for empty strings "id", "label", "currencyAmount", and "value"
  in a line item or a shipping option.

- Tests for invalid "value" in shipping options, e.g., "1..0" and "1/3".

BUG=587995
Committed: https://crrev.com/e5450401f78147b5ca8d246a2a38ca8fa504fa93
Cr-Commit-Position: refs/heads/master@{#391080}

[please use gerrit instead, 2016-05-02 00:19:52]

rouslan@chromium.org changed reviewers:
+ mek@chromium.org

[please use gerrit instead, 2016-05-02 00:19:53]

mek@, ptal.

Increasing code coverage in payments/ :-)

[Marijn Kruisselbrink, 2016-05-02 18:08:02]

lgtm. Although maybe elaborate in the CL description what tests you added.

[please use gerrit instead, 2016-05-02 19:03:36]

Description was changed from

==========
More thorough tests for PaymentDetails

BUG=587995
==========

to

==========
More thorough tests for PaymentDetails

- Tests for missing "amount" in a line item or a shipping option.

- Tests for empty strings "id", "label", "currencyAmount", and "value"
  in a line item or a shipping option.

- Tests for invalid "value" in shipping options, e.g., "1..0" and "1/3".

BUG=587995
==========

[please use gerrit instead, 2016-05-02 21:24:40]

On 2016/05/02 18:08:02, Marijn Kruisselbrink wrote:
> elaborate in the CL description what tests you added.

Done. Also placed the test helpers into anon namespace per our discussions on
other patches.

Sending to cq now.

[please use gerrit instead, 2016-05-02 21:25:05]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-05-02 21:25:05]

The patchset sent to the CQ was uploaded after l-g-t-m from mek@chromium.org
Link to the patchset: https://codereview.chromium.org/1938843002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-05-02 21:25:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938843002/20001

[commit-bot: I haz the power, 2016-05-02 22:43:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-02 22:44:03]

Description was changed from

==========
More thorough tests for PaymentDetails

- Tests for missing "amount" in a line item or a shipping option.

- Tests for empty strings "id", "label", "currencyAmount", and "value"
  in a line item or a shipping option.

- Tests for invalid "value" in shipping options, e.g., "1..0" and "1/3".

BUG=587995
==========

to

==========
More thorough tests for PaymentDetails

- Tests for missing "amount" in a line item or a shipping option.

- Tests for empty strings "id", "label", "currencyAmount", and "value"
  in a line item or a shipping option.

- Tests for invalid "value" in shipping options, e.g., "1..0" and "1/3".

BUG=587995

Committed: https://crrev.com/e5450401f78147b5ca8d246a2a38ca8fa504fa93
Cr-Commit-Position: refs/heads/master@{#391080}
==========

[commit-bot: I haz the power, 2016-05-02 22:44:05]

Patchset 2 (id:??) landed as
https://crrev.com/e5450401f78147b5ca8d246a2a38ca8fa504fa93
Cr-Commit-Position: refs/heads/master@{#391080}