More thorough tests for PaymentDetails

third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/JSONValuesForV8.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
@@ skipping 90 matching lines @@
 
 namespace blink {
 namespace {
 
 // Validates ShippingOption and PaymentItem dictionaries, which happen to have identical fields.
 template <typename T>
 void validateShippingOptionsOrPaymentItems(HeapVector<T> items, ExceptionState& exceptionState)
 {
     String errorMessage;
     for (const auto& item : items) {
-        if (!item.hasId()) {
+        if (!item.hasId() || item.id().isEmpty()) {
             exceptionState.throwTypeError("Item id required");
             return;
         }
 
-        if (!item.hasLabel()) {
+        if (!item.hasLabel() || item.label().isEmpty()) {
             exceptionState.throwTypeError("Item label required");
             return;
         }
 
         if (!item.hasAmount()) {
             exceptionState.throwTypeError("Currency amount required");
             return;
         }
 
         if (!item.amount().hasCurrencyCode()) {
@@ skipping 238 matching lines @@
 void PaymentRequest::cleanUp()
 {
     m_completeResolver.clear();
     m_showResolver.clear();
     if (m_clientBinding.is_bound())
         m_clientBinding.Close();
     m_paymentProvider.reset();
 }
 
 } // namespace blink