Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1938493002: [Reland] Fix ReadPixels from float fbo buffer in ES2/WebGL1. (Closed)

Created:
4 years, 7 months ago by Zhenyao Mo
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, darin-cc_chromium.org, haraken, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Fix ReadPixels from float fbo buffer in ES2/WebGL1. (The original reviewed CL is https://codereview.chromium.org/1927593005/) This CL change the default format/type from RGBA/UNSIGNED_BYTE to RGBA/FLOAT. Also, simplify querying IMPLMENTATION_READ_COLOR_FORMAT/TYPE by always calling down to the driver (even if the two enums are not supported) and fall back to internal decision if a GL error is generated. BUG=607283, 607936 TEST=webgl_conformance,webgl2_conformance R=piman@chromium.org,kbr@chromium.org,bajones@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true TBR=kbr@chromium.org,piman@chromium.org Committed: https://crrev.com/9192d283d15db880e62fcccdd02adda1c3ad0188 Cr-Commit-Position: refs/heads/master@{#390702}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -168 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 2 chunks +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +5 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 13 chunks +68 lines, -58 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 2 chunks +24 lines, -82 lines 0 comments Download
M gpu/command_buffer/tests/gl_readback_unittest.cc View 1 chunk +10 lines, -1 line 1 comment Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +15 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gl/gl_version_info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_version_info.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Zhenyao Mo
https://codereview.chromium.org/1938493002/diff/1/gpu/command_buffer/tests/gl_readback_unittest.cc File gpu/command_buffer/tests/gl_readback_unittest.cc (right): https://codereview.chromium.org/1938493002/diff/1/gpu/command_buffer/tests/gl_readback_unittest.cc#newcode147 gpu/command_buffer/tests/gl_readback_unittest.cc:147: // type is HALF_FLOAT_OES. Likely it's due to a ...
4 years, 7 months ago (2016-04-29 18:16:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938493002/1
4 years, 7 months ago (2016-04-29 18:17:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 18:23:09 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:27:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9192d283d15db880e62fcccdd02adda1c3ad0188
Cr-Commit-Position: refs/heads/master@{#390702}

Powered by Google App Engine
This is Rietveld 408576698