Chromium Code Reviews
Description[Reland] Fix ReadPixels from float fbo buffer in ES2/WebGL1.
(The original reviewed CL is https://codereview.chromium.org/1927593005/)
This CL change the default format/type from RGBA/UNSIGNED_BYTE to RGBA/FLOAT.
Also, simplify querying IMPLMENTATION_READ_COLOR_FORMAT/TYPE by
always calling down to the driver (even if the two enums are not
supported) and fall back to internal decision if a GL error is
generated.
BUG=607283, 607936
TEST=webgl_conformance,webgl2_conformance
R=piman@chromium.org,kbr@chromium.org,bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
TBR=kbr@chromium.org,piman@chromium.org
Committed: https://crrev.com/9192d283d15db880e62fcccdd02adda1c3ad0188
Cr-Commit-Position: refs/heads/master@{#390702}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 8 (4 generated)
|