Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: gpu/command_buffer/tests/gl_readback_unittest.cc

Issue 1938493002: [Reland] Fix ReadPixels from float fbo buffer in ES2/WebGL1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/tests/gl_readback_unittest.cc
diff --git a/gpu/command_buffer/tests/gl_readback_unittest.cc b/gpu/command_buffer/tests/gl_readback_unittest.cc
index c9038dc9973f6e632a9bb4ebe95bf39b5e801cbb..0c728e425f15d2b97124bb44d3db85bfeff0d6fc 100644
--- a/gpu/command_buffer/tests/gl_readback_unittest.cc
+++ b/gpu/command_buffer/tests/gl_readback_unittest.cc
@@ -141,7 +141,16 @@ static GLuint CompileShader(GLenum type, const char *data) {
return shader;
}
-TEST_F(GLReadbackTest, ReadPixelsFloat) {
+// TODO(zmo): ReadPixels with float type isn't implemented in ANGLE ES2
+// backend. crbug.com/607283.
+// TODO(zmo): This test also fails on some android devices when the readback
+// type is HALF_FLOAT_OES. Likely it's due to a driver bug. crbug.com/607936.
Zhenyao Mo 2016/04/29 18:16:48 This is the added part from the original CL: in th
+#if defined(OS_WIN) || defined(OS_ANDROID)
+#define MAYBE_ReadPixelsFloat DISABLED_ReadPixelsFloat
+#else
+#define MAYBE_ReadPixelsFloat ReadPixelsFloat
+#endif
+TEST_F(GLReadbackTest, MAYBE_ReadPixelsFloat) {
const GLsizei kTextureSize = 4;
const GLfloat kDrawColor[4] = { -10.9f, 0.5f, 10.5f, 100.12f };
const GLfloat kEpsilon = 0.01f;

Powered by Google App Engine
This is Rietveld 408576698