Issue 19384004: Proxies: Make 'with' work, plus minor other fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19384004: Proxies: Make 'with' work, plus minor other fixes (Closed)

Created:
7 years, 5 months ago by rossberg

Modified:
7 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Proxies: Make 'with' work, plus minor other fixes Also fixes internal exception handling in several places of the runtime. R=yangguo@chromium.org BUG=v8:1543 Committed: http://code.google.com/p/v8/source/detail?r=15781

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+492 lines, -27 lines)			Patch
M	src/contexts.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/heap.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/proxy.js	View	1 chunk	+6 lines, -2 lines	2 comments	Download
M	src/runtime.cc	View	6 chunks	+14 lines, -9 lines	0 comments	Download
M	test/mjsunit/harmony/proxies-for.js	View	4 chunks	+10 lines, -10 lines	0 comments	Download
A	test/mjsunit/harmony/proxies-with.js	View	1 chunk	+446 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

lgtm with a comment. https://codereview.chromium.org/19384004/diff/1/src/proxy.js File src/proxy.js (right): https://codereview.chromium.org/19384004/diff/1/src/proxy.js#newcode200 src/proxy.js:200: if (desc.enumerable) enumerableNames[count++] = names[i] ...

7 years, 5 months ago (2013-07-19 12:05:43 UTC) #2

rossberg

https://codereview.chromium.org/19384004/diff/1/src/proxy.js File src/proxy.js (right): https://codereview.chromium.org/19384004/diff/1/src/proxy.js#newcode200 src/proxy.js:200: if (desc.enumerable) enumerableNames[count++] = names[i] On 2013/07/19 12:05:43, Yang ...

7 years, 5 months ago (2013-07-19 14:05:02 UTC) #3

rossberg

7 years, 5 months ago (2013-07-19 14:07:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r15781 (presubmit successful).

Expand Messages | Collapse Messages