Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: test/mjsunit/harmony/proxies-for.js

Issue 19384004: Proxies: Make 'with' work, plus minor other fixes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/harmony/proxies-for.js
diff --git a/test/mjsunit/harmony/proxies-for.js b/test/mjsunit/harmony/proxies-for.js
index 3d419c6dcaf0d9f51ba454cec96a1b91d4a2cb85..d0f2a022fd176b1f548e69cbf8bc5edc7651a9d7 100644
--- a/test/mjsunit/harmony/proxies-for.js
+++ b/test/mjsunit/harmony/proxies-for.js
@@ -62,10 +62,10 @@ TestForIn(["b", "d"], {
getPropertyNames: function() { return ["a", "b", "c", "d", "e"] },
getPropertyDescriptor: function(k) {
switch (k) {
- case "a": return {enumerable: false, value: "3"};
- case "b": return {enumerable: true, get get() {}};
- case "c": return {value: 4};
- case "d": return {get enumerable() { return true }};
+ case "a": return {enumerable: false, value: "3", configurable: true};
+ case "b": return {enumerable: true, get get() {}, configurable: true};
+ case "c": return {value: 4, configurable: true};
+ case "d": return {get enumerable() { return true }, configurable: true};
default: return undefined;
}
}
@@ -103,7 +103,7 @@ function TestForInDerived2(create, properties, handler) {
TestForInDerived(["0", "a"], {
enumerate: function() { return [0, "a"] },
getPropertyDescriptor: function(k) {
- return k == "0" || k == "a" ? {} : undefined
+ return k == "0" || k == "a" ? {configurable: true} : undefined
}
})
@@ -111,7 +111,7 @@ TestForInDerived(["null", "a"], {
enumerate: function() { return this.enumerate2() },
enumerate2: function() { return [null, "a"] },
getPropertyDescriptor: function(k) {
- return k == "null" || k == "a" ? {} : undefined
+ return k == "null" || k == "a" ? {configurable: true} : undefined
}
})
@@ -119,10 +119,10 @@ TestForInDerived(["b", "d"], {
getPropertyNames: function() { return ["a", "b", "c", "d", "e"] },
getPropertyDescriptor: function(k) {
switch (k) {
- case "a": return {enumerable: false, value: "3"};
- case "b": return {enumerable: true, get get() {}};
- case "c": return {value: 4};
- case "d": return {get enumerable() { return true }};
+ case "a": return {enumerable: false, value: "3", configurable: true};
+ case "b": return {enumerable: true, get get() {}, configurable: true};
+ case "c": return {value: 4, configurable: true};
+ case "d": return {get enumerable() { return true }, configurable: true};
default: return undefined;
}
}
« src/proxy.js ('K') | « src/runtime.cc ('k') | test/mjsunit/harmony/proxies-with.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698