Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1938393003: [webnfc] WIP: Implement push method for Android nfc mojo service.

Created:
4 years, 7 months ago by shalamov
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@implement_nfc_push_in_blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] WIP: Implement push method for Android nfc mojo service. Initial implementation of Android NFC mojo service that is used by blink nfc module. Follow-up patches will add support for nfc.watch / nfc.cancelWatch methods. BUG=520391 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+769 lines, -22 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java View 2 chunks +5 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/nfc/NfcIntentHandler.java View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/service_registrar_android.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/mojo/service_registrar_android.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M content/content.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ServiceRegistrar.java View 3 chunks +30 lines, -1 line 0 comments Download
A device/nfc/android/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A device/nfc/android/java/src/org/chromium/device/nfc/NfcImpl.java View 1 chunk +653 lines, -0 lines 0 comments Download
M device/nfc/nfc.gyp View 2 chunks +22 lines, -17 lines 0 comments Download

Depends on Patchset:

Issue 1708543002 Patch 280001

Messages

Total messages: 1 (1 generated)
shalamov
4 years, 7 months ago (2016-05-04 08:00:52 UTC) #1 
Description was changed from

==========
[webnfc] WIP: Implement push method for Android nfc mojo service.

Initial implementation of Android NFC mojo service that
is used by blink nfc module. Follow-up patches will add
support for nfc.watch / nfc.cancelWatch methods.

BUG=520391
==========

to

==========
[webnfc] WIP: Implement push method for Android nfc mojo service.

Initial implementation of Android NFC mojo service that
is used by blink nfc module. Follow-up patches will add
support for nfc.watch / nfc.cancelWatch methods.

BUG=520391
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698