Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1938173002: Fix a bug that progress notification can linger after download completes (Closed)

Created:
4 years, 7 months ago by qinmin
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix a bug that progress notification can linger after download completes If the size of the download is unknwon, percentage completed is always -1. The current code doesn't add the download into SharedPreference in that case. As a result, the SharedPref will not be found when download completes. This causes notifyDownloadSuccess() to early return. This CL fix the issue by always adding the download entry into the sharedprefs. TBR=tedchoc@chromium.org BUG=608091 Review-Url: https://codereview.chromium.org/1939593002 Cr-Commit-Position: refs/heads/master@{#390970} (cherry picked from commit f0e99eea9df4ba893cb307960f3bc7194e469bd7) Committed: https://chromium.googlesource.com/chromium/src/+/ab9b8915bbd8eb8d21c24de8a4929fd020b93c8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
qinmin
4 years, 7 months ago (2016-05-02 21:04:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab9b8915bbd8eb8d21c24de8a4929fd020b93c8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698