Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1939593002: Fix a bug that progress notification can linger after download completes (Closed)

Created:
4 years, 7 months ago by qinmin
Modified:
4 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that progress notification can linger after download completes If the size of the download is unknwon, percentage completed is always -1. The current code doesn't add the download into SharedPreference in that case. As a result, the SharedPref will not be found when download completes. This causes notifyDownloadSuccess() to early return. This CL fix the issue by always adding the download entry into the sharedprefs. BUG=608091 Committed: https://crrev.com/f0e99eea9df4ba893cb307960f3bc7194e469bd7 Cr-Commit-Position: refs/heads/master@{#390970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 7 months ago (2016-04-30 00:27:09 UTC) #2
Ted C
lgtm
4 years, 7 months ago (2016-05-02 15:59:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939593002/1
4 years, 7 months ago (2016-05-02 16:21:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 17:07:36 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:09:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0e99eea9df4ba893cb307960f3bc7194e469bd7
Cr-Commit-Position: refs/heads/master@{#390970}

Powered by Google App Engine
This is Rietveld 408576698