More define cleanup.

More define cleanup.

This CL converts defines into constants, enums, enum classes or removes them
as needed.

Committed: https://pdfium.googlesource.com/pdfium/+/8f4bf9a8ac211e150f7fa4d8ed061f264cb3aa9e

[dsinclair, 2016-05-02 20:59:54]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-02 20:59:55]

PTAL.

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (left):

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:33: #define FPDFTEXT_RIGHT 1
RLTB and RIGHT were both the same value so I removed RLTB.

[Tom Sepez, 2016-05-02 21:45:39]

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (left):

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:33: #define FPDFTEXT_RIGHT 1
On 2016/05/02 20:59:55, dsinclair wrote:
> RLTB and RIGHT were both the same value so I removed RLTB.

Acknowledged.

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:734: if (direction != FPDFTEXT_LEFT && direction
!= FPDFTEXT_RIGHT)
given values of -1 and 1, is it possible that they were also silently using 0 as
a "dont't know"?

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1279: FPDFText_MarkedContent bPreMKC =
PreMarkedContent(Obj);
prolly shoujld be ePreMKC since its an enum not a bool.

https://codereview.chromium.org/1938163002/diff/1/xfa/fwl/core/fwl_noteimp.h
File xfa/fwl/core/fwl_noteimp.h (right):

https://codereview.chromium.org/1938163002/diff/1/xfa/fwl/core/fwl_noteimp.h#...
xfa/fwl/core/fwl_noteimp.h:17: FWL_KEYFLAG_Ctrl = (1 << 0),
nit: ()

https://codereview.chromium.org/1938163002/diff/1/xfa/fwl/core/fwl_widgetmgri...
File xfa/fwl/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1938163002/diff/1/xfa/fwl/core/fwl_widgetmgri...
xfa/fwl/core/fwl_widgetmgrimp.cpp:25: FX_BOOL bNotNeedRepaint;
can these be bools?

https://codereview.chromium.org/1938163002/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_eventpseudomodel.h (right):

https://codereview.chromium.org/1938163002/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_eventpseudomodel.h:15: CommitKey = 1,
Subsequent initializers not needed, and you run the risk of accidental
duplication by being explicit.

[dsinclair, 2016-05-03 13:58:16]

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (left):

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:734: if (direction != FPDFTEXT_LEFT && direction
!= FPDFTEXT_RIGHT)
On 2016/05/02 21:45:39, Tom Sepez wrote:
> given values of -1 and 1, is it possible that they were also silently using 0
as
> a "dont't know"? 


Turns out, GetWordBreak is never called. Removed.

Now, the only time it's checked is to compare it to ::Right. The setter methods
would have previously set 1 or 0, which means ::Left was actually impossible. It
will now set ::Left or ::Right depending on the value set in the viewer
preferences.

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1279: FPDFText_MarkedContent bPreMKC =
PreMarkedContent(Obj);
On 2016/05/02 21:45:39, Tom Sepez wrote:
> prolly shoujld be ePreMKC since its an enum not a bool.

Sigh, hungarian notation, so verbose.

https://codereview.chromium.org/1938163002/diff/1/xfa/fwl/core/fwl_noteimp.h
File xfa/fwl/core/fwl_noteimp.h (right):

https://codereview.chromium.org/1938163002/diff/1/xfa/fwl/core/fwl_noteimp.h#...
xfa/fwl/core/fwl_noteimp.h:17: FWL_KEYFLAG_Ctrl = (1 << 0),
On 2016/05/02 21:45:39, Tom Sepez wrote:
> nit: ()

Done.

https://codereview.chromium.org/1938163002/diff/1/xfa/fwl/core/fwl_widgetmgri...
File xfa/fwl/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1938163002/diff/1/xfa/fwl/core/fwl_widgetmgri...
xfa/fwl/core/fwl_widgetmgrimp.cpp:25: FX_BOOL bNotNeedRepaint;
On 2016/05/02 21:45:39, Tom Sepez wrote:
> can these be bools?

Done.

https://codereview.chromium.org/1938163002/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_eventpseudomodel.h (right):

https://codereview.chromium.org/1938163002/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_eventpseudomodel.h:15: CommitKey = 1,
On 2016/05/02 21:45:39, Tom Sepez wrote:
> Subsequent initializers not needed, and you run the risk of accidental
> duplication by being explicit.

Done.

[dsinclair, 2016-05-04 14:03:08]

ping

[Tom Sepez, 2016-05-04 20:31:13]

lgtm

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1938163002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1279: FPDFText_MarkedContent bPreMKC =
PreMarkedContent(Obj);
On 2016/05/03 13:58:16, dsinclair wrote:
> On 2016/05/02 21:45:39, Tom Sepez wrote:
> > prolly shoujld be ePreMKC since its an enum not a bool.
> 
> Sigh, hungarian notation, so verbose.

Actually, it points out a problem that when the type of a variable changes, so
must its name, which makes generic programming difficult and why its a bad idea
in general.

[dsinclair, 2016-05-04 20:34:43]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-05-04 20:34:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938163002/40001

[commit-bot: I haz the power, 2016-05-04 20:51:54]

Description was changed from

==========
More define cleanup.

This CL converts defines into constants, enums, enum classes or removes them
as needed.
==========

to

==========
More define cleanup.

This CL converts defines into constants, enums, enum classes or removes them
as needed.

Committed:
https://pdfium.googlesource.com/pdfium/+/8f4bf9a8ac211e150f7fa4d8ed061f264cb3...
==========

[commit-bot: I haz the power, 2016-05-04 20:51:55]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/8f4bf9a8ac211e150f7fa4d8ed061f264cb3...