WebUI: Fix favicon URL regression.

WebUI: Fix favicon URL regression.

This was caused by https://codereview.chromium.org/1914073005, because it
assumed that there are only two types of URLs, 'iconurl' and 'origin'. There are
actually three, 'iconurl', 'origin' and '' (empty string). In order to preserve
previous behavior. getFaviconImageSet() should not handle 'origin' URLs.

BUG=608263
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1cf3369501c9d3fa1bceff174beab20c1555832f
Cr-Commit-Position: refs/heads/master@{#391151}

[dpapad, 2016-05-02 18:17:28]

Description was changed from

==========
WebUI: Fix favicon URL regression.

This was caused by https://codereview.chromium.org/1914073005, because it
assumed that there are only two types of URLs, 'iconurl' and 'origin'. There are
actually three, 'iconurl', 'origin' and '' (empty string). In order to preserve
previous behavior. getFaviconImageSet() should not handle 'origin' URLs.

BUG=608263
==========

to

==========
WebUI: Fix favicon URL regression.

This was caused by https://codereview.chromium.org/1914073005, because it
assumed that there are only two types of URLs, 'iconurl' and 'origin'. There are
actually three, 'iconurl', 'origin' and '' (empty string). In order to preserve
previous behavior. getFaviconImageSet() should not handle 'origin' URLs.

BUG=608263
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-02 18:22:55]

Patchset #2 (id:20001) has been deleted

[dpapad, 2016-05-02 18:22:59]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-05-02 18:29:23]

Regression was caused by logical error. I thought that 'origin' and '' was
handled identically, but they are actually not, see
https://code.google.com/p/chromium/codesearch#chromium/src/components/favicon....
This change restores the previous behavior for non-favicon URLs.

[dpapad, 2016-05-02 18:29:35]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-05-02 18:29:36]

Regression was caused by logical error. I thought that 'origin' and '' was
handled identically, but they are actually not, see
https://code.google.com/p/chromium/codesearch#chromium/src/components/favicon....
This change restores the previous behavior for non-favicon URLs.

[Dan Beam, 2016-05-03 01:20:26]

lgtm

[dpapad, 2016-05-03 01:25:12]

On 2016/05/03 at 01:20:26, dbeam wrote:
> lgtm

Thank you.

[dpapad, 2016-05-03 01:25:15]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-05-03 01:25:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938063002/40001

[commit-bot: I haz the power, 2016-05-03 01:39:25]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-05-03 01:41:28]

Description was changed from

==========
WebUI: Fix favicon URL regression.

This was caused by https://codereview.chromium.org/1914073005, because it
assumed that there are only two types of URLs, 'iconurl' and 'origin'. There are
actually three, 'iconurl', 'origin' and '' (empty string). In order to preserve
previous behavior. getFaviconImageSet() should not handle 'origin' URLs.

BUG=608263
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Fix favicon URL regression.

This was caused by https://codereview.chromium.org/1914073005, because it
assumed that there are only two types of URLs, 'iconurl' and 'origin'. There are
actually three, 'iconurl', 'origin' and '' (empty string). In order to preserve
previous behavior. getFaviconImageSet() should not handle 'origin' URLs.

BUG=608263
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1cf3369501c9d3fa1bceff174beab20c1555832f
Cr-Commit-Position: refs/heads/master@{#391151}
==========

[commit-bot: I haz the power, 2016-05-03 01:41:29]

Patchset 1 (id:??) landed as
https://crrev.com/1cf3369501c9d3fa1bceff174beab20c1555832f
Cr-Commit-Position: refs/heads/master@{#391151}