Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 1914073005: Make getFaviconImageSet work with all expected URL types. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make getFaviconImageSet work with all expected URL types. BUG=606445 Committed: https://crrev.com/e34687cdc6fed5fd7d1eede2fb6a0aed5f26d466 Cr-Commit-Position: refs/heads/master@{#390137}

Patch Set 1 : Nit #

Total comments: 8

Patch Set 2 : Address comments #

Patch Set 3 : case insensitive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M chrome/browser/resources/options/search_engine_manager_engine_list.js View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/data/webui/util_test.html View 1 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/test/data/webui/webui_resource_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/js/util.js View 1 2 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dpapad
The old Options code was not using the getFaviconImageSet() helper method, because it was expecting ...
4 years, 8 months ago (2016-04-27 00:58:42 UTC) #3
Dan Beam
lgtm, but you should probably try this at different DPIs as well (if you haven't ...
4 years, 7 months ago (2016-04-27 02:18:31 UTC) #4
dpapad
Tried with --force-device-scale-factor=2 and verified that the correct URLs were produced. https://codereview.chromium.org/1914073005/diff/20001/chrome/browser/resources/options/search_engine_manager_engine_list.js File chrome/browser/resources/options/search_engine_manager_engine_list.js (right): ...
4 years, 7 months ago (2016-04-27 17:21:47 UTC) #5
dpapad
https://codereview.chromium.org/1914073005/diff/20001/ui/webui/resources/js/util.js File ui/webui/resources/js/util.js (right): https://codereview.chromium.org/1914073005/diff/20001/ui/webui/resources/js/util.js#newcode333 ui/webui/resources/js/util.js:333: var FAVICON_URL_REGEX = /\.ico$/; On 2016/04/27 at 17:21:47, dpapad ...
4 years, 7 months ago (2016-04-27 17:24:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914073005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914073005/60001
4 years, 7 months ago (2016-04-27 17:33:30 UTC) #9
Dan Beam
still lgtm https://codereview.chromium.org/1914073005/diff/20001/ui/webui/resources/js/util.js File ui/webui/resources/js/util.js (right): https://codereview.chromium.org/1914073005/diff/20001/ui/webui/resources/js/util.js#newcode333 ui/webui/resources/js/util.js:333: var FAVICON_URL_REGEX = /\.ico$/; On 2016/04/27 17:24:25, ...
4 years, 7 months ago (2016-04-27 18:46:57 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-04-27 18:51:57 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:11:34 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e34687cdc6fed5fd7d1eede2fb6a0aed5f26d466
Cr-Commit-Position: refs/heads/master@{#390137}

Powered by Google App Engine
This is Rietveld 408576698