Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1938043002: Merge to M51: Don't send focus accessibility events when tab isn't focused. (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge to M51: Don't send focus accessibility events when tab isn't focused. This regressed in r383885 (https://codereview.chromium.org/1815933002). I meant to check if the focus callback was null, but instead I was checking if the lazy instance pointer to the callback was null, which is never true. BUG=608033 Review-Url: https://codereview.chromium.org/1932383002 Cr-Commit-Position: refs/heads/master@{#390772} (cherry picked from commit e7d3cad741a52f6d40bc14b211c9fe372f57481d) Committed: https://chromium.googlesource.com/chromium/src/+/daae3dc469b408b754e019bf49513494790cfc33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 7 months ago (2016-05-02 17:37:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
daae3dc469b408b754e019bf49513494790cfc33.

Powered by Google App Engine
This is Rietveld 408576698