Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1932383002: Don't send focus accessibility events when tab isn't focused. (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't send focus accessibility events when tab isn't focused. This regressed in r383885 (https://codereview.chromium.org/1815933002). I meant to check if the focus callback was null, but instead I was checking if the lazy instance pointer to the callback was null, which is never true. BUG=608033 Committed: https://crrev.com/e7d3cad741a52f6d40bc14b211c9fe372f57481d Cr-Commit-Position: refs/heads/master@{#390772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dmazzoni
4 years, 7 months ago (2016-04-29 20:47:01 UTC) #2
nektarios
lgtm
4 years, 7 months ago (2016-04-29 20:53:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932383002/1
4 years, 7 months ago (2016-04-29 20:53:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 21:47:16 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7d3cad741a52f6d40bc14b211c9fe372f57481d
Cr-Commit-Position: refs/heads/master@{#390772}

Powered by Google App Engine
This is Rietveld 408576698