Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 1937813002: Cancel asynchronously in allClientsAndObserversRemoved() except for Raw type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/Resource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp
index cf9ef1e62c497b4ebc069d841b93025ee0e89b3c..6c23408758d9af40db04572e91476aa76ebbb761 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.cpp
+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp
@@ -702,7 +702,7 @@ void Resource::allClientsAndObserversRemoved()
{
if (!m_loader)
return;
- if (m_type == MainResource || m_type == Raw || !memoryCache()->contains(this))
+ if (m_type == Raw)
Nate Chapin 2016/05/02 21:17:06 I assume this case is really still needed? Ideally
hiroshige 2016/05/03 03:36:48 I expect we can always cancel asynchronously. Howe
cancelTimerFired(&m_cancelTimer);
else if (!m_cancelTimer.isActive())
m_cancelTimer.startOneShot(0, BLINK_FROM_HERE);

Powered by Google App Engine
This is Rietveld 408576698