Cancel asynchronously in allClientsAndObserversRemoved() except for Raw type

third_party/WebKit/Source/core/fetch/Resource.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 684 matching lines @@
             memoryCache()->prune(this);
         }
     }
     // This object may be dead here.
 }
 
 void Resource::allClientsAndObserversRemoved()
 {
     if (!m_loader)
         return;
-    if (m_type == MainResource || m_type == Raw || !memoryCache()->contains(this))
+    if (m_type == Raw)

[Nate Chapin, 2016/05/02 21:17:06]

I assume this case is really still needed? Ideally we'd always cancel
asynchronously.

[hiroshige, 2016/05/03 03:36:48]

I expect we can always cancel asynchronously. However, cancelling Raw type
Resource causes some more test failures and probably it can be fixed in a better
way after you remove |memoryCache()->remove(this);| in
Resource::cancelTimerFired() in https://codereview.chromium.org/1923003002/ and
I make references from Inspector to Resource weak in
https://codereview.chromium.org/1807323002/.

         cancelTimerFired(&m_cancelTimer);
     else if (!m_cancelTimer.isActive())
         m_cancelTimer.startOneShot(0, BLINK_FROM_HERE);
 
     unlock();
 }
 
 void Resource::cancelTimerFired(Timer<Resource>* timer)
 {
     ASSERT_UNUSED(timer, timer == &m_cancelTimer);
@@ skipping 358 matching lines @@
     case Resource::Media:
         return "Media";
     case Resource::Manifest:
         return "Manifest";
     }
     ASSERT_NOT_REACHED();
     return "Unknown";
 }
 
 } // namespace blink