Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1937743002: Tidy up releasing of AssociatedURLLoader's client references. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up releasing of AssociatedURLLoader's client references. Make the releasing of client references a bit more solid and consistent. R= BUG=606998 Committed: https://crrev.com/2aaedda2430ecad19a8ac4427c145d1b093f3df9 Cr-Commit-Position: refs/heads/master@{#390873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M third_party/WebKit/Source/web/AssociatedURLLoader.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 6 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-01 07:23:47 UTC) #3
haraken
LGTM
4 years, 7 months ago (2016-05-01 07:53:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937743002/1
4 years, 7 months ago (2016-05-01 21:49:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-01 21:53:26 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2aaedda2430ecad19a8ac4427c145d1b093f3df9 Cr-Commit-Position: refs/heads/master@{#390873}
4 years, 7 months ago (2016-05-01 21:54:29 UTC) #16
tyoshino (SeeGerritForStatus)
4 years, 7 months ago (2016-05-02 04:51:53 UTC) #17
Message was sent while issue was closed.
lgtm

Thanks!

Powered by Google App Engine
This is Rietveld 408576698