Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: third_party/WebKit/Source/web/AssociatedURLLoader.h

Issue 1937743002: Tidy up releasing of AssociatedURLLoader's client references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/AssociatedURLLoader.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // Called by ClientAdapter to handle completion of loading. 64 // Called by ClientAdapter to handle completion of loading.
65 void clientAdapterDone(); 65 void clientAdapterDone();
66 66
67 private: 67 private:
68 class ClientAdapter; 68 class ClientAdapter;
69 class Observer; 69 class Observer;
70 70
71 void cancelLoader(); 71 void cancelLoader();
72 void disposeObserver(); 72 void disposeObserver();
73 73
74 WebURLLoaderClient* releaseClient()
75 {
76 WebURLLoaderClient* client = m_client;
77 m_client = nullptr;
78 return client;
79 }
80
74 WebURLLoaderClient* m_client; 81 WebURLLoaderClient* m_client;
75 WebURLLoaderOptions m_options; 82 WebURLLoaderOptions m_options;
76 83
77 // An adapter which converts the DocumentThreadableLoaderClient method 84 // An adapter which converts the DocumentThreadableLoaderClient method
78 // calls into the WebURLLoaderClient method calls. 85 // calls into the WebURLLoaderClient method calls.
79 OwnPtr<ClientAdapter> m_clientAdapter; 86 OwnPtr<ClientAdapter> m_clientAdapter;
80 OwnPtr<DocumentThreadableLoader> m_loader; 87 OwnPtr<DocumentThreadableLoader> m_loader;
81 88
82 // A ContextLifecycleObserver for cancelling |m_loader| when the Document 89 // A ContextLifecycleObserver for cancelling |m_loader| when the Document
83 // is detached. 90 // is detached.
84 Persistent<Observer> m_observer; 91 Persistent<Observer> m_observer;
85 }; 92 };
86 93
87 } // namespace blink 94 } // namespace blink
88 95
89 #endif 96 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/AssociatedURLLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698