Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1937273002: Reland of Add PDFium build_overrides (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add PDFium build_overrides This reverts commit e43a2442a5e5e1000021caf9f692b69208e1e53c. This CL adds the build override settings so we can enable XFA in GN builds in the future. BUG=chromium:62400 Committed: https://crrev.com/b986e46f8ebf7f0f6b72ad9b6f19a07ea2dde233 Cr-Commit-Position: refs/heads/master@{#391227}

Patch Set 1 #

Patch Set 2 : Roll DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
A build_overrides/pdfium.gni View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL. PDFium change at: https://codereview.chromium.org/1936313002/ I'll update the DEPS line when that lands.
4 years, 7 months ago (2016-05-02 18:45:21 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-02 23:58:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937273002/20001
4 years, 7 months ago (2016-05-03 13:26:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 14:34:19 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 14:35:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b986e46f8ebf7f0f6b72ad9b6f19a07ea2dde233
Cr-Commit-Position: refs/heads/master@{#391227}

Powered by Google App Engine
This is Rietveld 408576698