Make dart:collection strong-mode clean.

Make dart:collection strong-mode clean.

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/e19addf23efb536b3d1b23438cbb414f81faef7d

[floitsch, 2016-05-04 13:47:40]

floitsch@google.com changed reviewers:
+ leafp@google.com

[floitsch, 2016-05-04 13:47:41]

FYI: currently this CL triggers an assert in the VM.
I have filed a bug, and Regis is on it. I don't expect changes to this CL
because of the assert.

[Leaf, 2016-05-06 16:05:44]

lgtm

[sra1, 2016-05-06 18:12:16]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-05-06 18:12:17]

To avoid performance problems on dart2js like we had with Futures dart2js,
rewrite every occurrence of

   x as T

as

   x as Object/*=T*/

https://chromiumcodereview.appspot.com/1937103002/diff/20001/sdk/lib/collecti...
File sdk/lib/collection/queue.dart (right):

https://chromiumcodereview.appspot.com/1937103002/diff/20001/sdk/lib/collecti...
sdk/lib/collection/queue.dart:296: list.addLast(e as E);
fix

https://chromiumcodereview.appspot.com/1937103002/diff/20001/sdk/lib/collecti...
sdk/lib/collection/queue.dart:501: queue._table[i] = elements[i] as E;
fix

https://chromiumcodereview.appspot.com/1937103002/diff/20001/sdk/lib/collecti...
sdk/lib/collection/queue.dart:512: result.addLast(element as E);
fix

https://chromiumcodereview.appspot.com/1937103002/diff/20001/sdk/lib/collecti...
File sdk/lib/collection/splay_tree.dart (right):

https://chromiumcodereview.appspot.com/1937103002/diff/20001/sdk/lib/collecti...
sdk/lib/collection/splay_tree.dart:290: other.forEach((k, v) { result[k as K] =
v as V; });
'k as K' is going to be horribly expensive in dart2js.

use 'k as Object/*=K*/' instead

Fix throughout.

[floitsch, 2016-05-10 14:12:31]

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/queu...
File sdk/lib/collection/queue.dart (right):

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/queu...
sdk/lib/collection/queue.dart:296: list.addLast(e as E);
On 2016/05/06 18:12:17, sra1 wrote:
> fix

Done.

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/queu...
sdk/lib/collection/queue.dart:501: queue._table[i] = elements[i] as E;
On 2016/05/06 18:12:17, sra1 wrote:
> fix

Done.

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/queu...
sdk/lib/collection/queue.dart:512: result.addLast(element as E);
On 2016/05/06 18:12:17, sra1 wrote:
> fix

Done.

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/spla...
File sdk/lib/collection/splay_tree.dart (right):

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/spla...
sdk/lib/collection/splay_tree.dart:290: other.forEach((k, v) { result[k as K] =
v as V; });
On 2016/05/06 18:12:17, sra1 wrote:
> 'k as K' is going to be horribly expensive in dart2js.
> 
> use 'k as Object/*=K*/' instead
> 
> Fix throughout.

Done.

[floitsch, 2016-05-11 14:28:47]

Description was changed from

==========
Make dart:collection strong-mode clean.
==========

to

==========
Make dart:collection strong-mode clean.

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e19addf23efb536b3d1b23438cbb414f81faef7d
==========

[floitsch, 2016-05-11 14:28:49]

Committed patchset #4 (id:60001) manually as
e19addf23efb536b3d1b23438cbb414f81faef7d (presubmit successful).

[sra1, 2016-05-13 03:00:13]

https://codereview.chromium.org/1937103002/diff/60001/sdk/lib/collection/queu...
File sdk/lib/collection/queue.dart (right):

https://codereview.chromium.org/1937103002/diff/60001/sdk/lib/collection/queu...
sdk/lib/collection/queue.dart:139: }
This is a breaking change since DoubleLinkedQueueEntry no longer has a remove()
method.

There are a bunch of additional warnings when compiling swarm due to this
change.

[Lasse Reichstein Nielsen, 2016-05-13 05:31:06]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-05-13 05:31:10]

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/hash...
File sdk/lib/collection/hash_map.dart (right):

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/hash...
sdk/lib/collection/hash_map.dart:105: other.forEach((k, v) { result[k as K] = v
as V; });
I saw some other code be changed to 
  k as Object/*=K*/
for performance in spec mode. Would that make sense here too?

https://codereview.chromium.org/1937103002/diff/60001/sdk/lib/collection/queu...
File sdk/lib/collection/queue.dart (right):

https://codereview.chromium.org/1937103002/diff/60001/sdk/lib/collection/queu...
sdk/lib/collection/queue.dart:123: factory DoubleLinkedQueueEntry(E element) =
_UserDoubleLinkedQueueEntry<E>;
This changes a generative constructor to a factory constructor.
If any class extends DoubleLinkedQueueEntry, it will stop working.

(I guess this is another lesson in separating interface and implementation :)

[Lasse Reichstein Nielsen, 2016-05-13 06:57:52]

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/hash...
File sdk/lib/collection/hash_map.dart (right):

https://codereview.chromium.org/1937103002/diff/20001/sdk/lib/collection/hash...
sdk/lib/collection/hash_map.dart:105: other.forEach((k, v) { result[k as K] = v
as V; });
That was an old comment I forgot to send at the time, you already fixed that.

[floitsch, 2016-05-13 17:12:01]

https://codereview.chromium.org/1937103002/diff/60001/sdk/lib/collection/queu...
File sdk/lib/collection/queue.dart (right):

https://codereview.chromium.org/1937103002/diff/60001/sdk/lib/collection/queu...
sdk/lib/collection/queue.dart:123: factory DoubleLinkedQueueEntry(E element) =
_UserDoubleLinkedQueueEntry<E>;
On 2016/05/13 05:31:09, Lasse Reichstein Nielsen wrote:
> This changes a generative constructor to a factory constructor.
> If any class extends DoubleLinkedQueueEntry, it will stop working.
> 
> (I guess this is another lesson in separating interface and implementation :)

Fixed in https://codereview.chromium.org/1973903005

https://codereview.chromium.org/1937103002/diff/60001/sdk/lib/collection/queu...
sdk/lib/collection/queue.dart:139: }
On 2016/05/13 03:00:13, sra1 wrote:
> This is a breaking change since DoubleLinkedQueueEntry no longer has a
remove()
> method.
> 
> There are a bunch of additional warnings when compiling swarm due to this
> change.

Argh. Missed the 'remove' function.
Fixing in https://codereview.chromium.org/1973903005