Issue 1973903005: Make DoubleLinkedQueueEntry subclassable again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1973903005: Make DoubleLinkedQueueEntry subclassable again. (Closed)

Created:
4 years, 7 months ago by floitsch

Modified:
4 years, 7 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, sra1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make DoubleLinkedQueueEntry subclassable again. Also, add back the `remove` function that was accidentally removed. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/1e3b98278a3282e17139c6e9924918fb16e7da90

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -51 lines)			Patch
	M	sdk/lib/collection/queue.dart	View		13 chunks	+33 lines, -51 lines	0 comments	Download

Total messages: 5 (2 generated)

floitsch

Fixes the concerns raised in https://codereview.chromium.org/1937103002/

4 years, 7 months ago (2016-05-13 17:12:09 UTC) #2

floitsch

4 years, 7 months ago (2016-05-17 10:54:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1e3b98278a3282e17139c6e9924918fb16e7da90 (presubmit successful).