Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1937053002: Remove (almost) unused read/writeFunctionPtr API. (Closed)

Created:
4 years, 7 months ago by Brian Osman
Modified:
4 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -46 lines) Patch
M include/core/SkWriteBuffer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkReadBuffer.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 1 1 chunk +0 lines, -18 lines 0 comments Download
M src/core/SkValidatingReadBuffer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937053002/1
4 years, 7 months ago (2016-05-02 14:21:13 UTC) #5
Brian Osman
More dead code. The ImageFilterMatrix test still passes - is there a preferred way to ...
4 years, 7 months ago (2016-05-02 14:22:30 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/9295)
4 years, 7 months ago (2016-05-02 14:23:05 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937053002/20001
4 years, 7 months ago (2016-05-02 14:26:23 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/8279)
4 years, 7 months ago (2016-05-02 14:29:22 UTC) #12
reed1
lgtm
4 years, 7 months ago (2016-05-02 14:40:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937053002/20001
4 years, 7 months ago (2016-05-02 14:50:13 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 14:51:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/18f13f3673c20fec220a1594b3174f9dcab35c5d

Powered by Google App Engine
This is Rietveld 408576698