Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: tests/ImageFilterTest.cpp

Issue 1937053002: Remove (almost) unused read/writeFunctionPtr API. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkValidatingReadBuffer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/ImageFilterTest.cpp
diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp
index 56b3aaf5cdf6c26be8dab06b7e78c780e0aaeb9a..592f5c6b865636ed03dd2b0d1ac2864b6f5af75a 100644
--- a/tests/ImageFilterTest.cpp
+++ b/tests/ImageFilterTest.cpp
@@ -65,9 +65,7 @@ protected:
}
void flatten(SkWriteBuffer& buffer) const override {
- this->INHERITED::flatten(buffer);
- buffer.writeFunctionPtr(fReporter);
- buffer.writeMatrix(fExpectedMatrix);
+ SkDEBUGFAIL("Should never get here");
}
private:
@@ -289,11 +287,8 @@ private:
}
sk_sp<SkFlattenable> MatrixTestImageFilter::CreateProc(SkReadBuffer& buffer) {
- SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1);
- skiatest::Reporter* reporter = (skiatest::Reporter*)buffer.readFunctionPtr();
- SkMatrix matrix;
- buffer.readMatrix(&matrix);
- return MatrixTestImageFilter::Make(reporter, matrix);
+ SkDEBUGFAIL("Should never get here");
+ return nullptr;
}
#ifndef SK_IGNORE_TO_STRING
« no previous file with comments | « src/core/SkValidatingReadBuffer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698