third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h - Issue 1937033002: Fix crash in CSSStyleSheetResource::appendData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h

Issue 1937033002: Fix crash in CSSStyleSheetResource::appendData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move CSSPreloaderResourceClient to the Oilpan heap, make it a ResourceOwner Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h

index 49b57dcd2d4dd3e08e96e2270773b8e1b642e2aa..bbdcc9096705e01a90c7f922db6b0395a1acc2d0 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h

+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h

@@ -51,7 +51,7 @@ private:

explicit HTMLResourcePreloader(Document&);

Member<Document> m_document;

- HashSet<OwnPtr<CSSPreloaderResourceClient>> m_cssPreloaders;

+ HeapVector<Member<CSSPreloaderResourceClient>> m_cssPreloaders;

Nate Chapin 2016/05/03 20:52:13 Why not HeapHashSet?

Charlie Harrison 2016/05/04 13:26:36 I don't think it's necessary, so I just went with

};

} // namespace blink