third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h - Issue 1937033002: Fix crash in CSSStyleSheetResource::appendData

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h

Issue 1937033002: Fix crash in CSSStyleSheetResource::appendData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move CSSPreloaderResourceClient to the Oilpan heap, make it a ResourceOwner Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All Rights Reserved.	2 * Copyright (C) 2013 Google Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 int countPreloads();	44 int countPreloads();

45 DECLARE_TRACE();	45 DECLARE_TRACE();

46	46

47 protected:	47 protected:

48 void preload(PassOwnPtr<PreloadRequest>, const NetworkHintsInterface&) overr ide;	48 void preload(PassOwnPtr<PreloadRequest>, const NetworkHintsInterface&) overr ide;

49	49

50 private:	50 private:

51 explicit HTMLResourcePreloader(Document&);	51 explicit HTMLResourcePreloader(Document&);

52	52

53 Member<Document> m_document;	53 Member<Document> m_document;

54 HashSet<OwnPtr<CSSPreloaderResourceClient>> m_cssPreloaders;	54 HeapVector<Member<CSSPreloaderResourceClient>> m_cssPreloaders;
	Nate Chapin 2016/05/03 20:52:13 Why not HeapHashSet? Why not HeapHashSet? Charlie Harrison 2016/05/04 13:26:36 I don't think it's necessary, so I just went with Show quoted text On 2016/05/03 20:52:13, Nate Chapin wrote: > Why not HeapHashSet? I don't think it's necessary, so I just went with the simplest expandable data structure available.
55 };	55 };

56	56

57 } // namespace blink	57 } // namespace blink

58	58

59 #endif	59 #endif

OLD	NEW