Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

Issue 1937033002: Fix crash in CSSStyleSheetResource::appendData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move CSSPreloaderResourceClient to the Oilpan heap, make it a ResourceOwner Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
index 88bf5409336fef8be9b651a9d47d7c5d63322a54..b9a7c933569c67c80594f18426eebd87e326e0b8 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
@@ -47,6 +47,7 @@ HTMLResourcePreloader* HTMLResourcePreloader::create(Document& document)
DEFINE_TRACE(HTMLResourcePreloader)
{
visitor->trace(m_document);
+ visitor->trace(m_cssPreloaders);
}
int HTMLResourcePreloader::countPreloads()
@@ -85,9 +86,7 @@ void HTMLResourcePreloader::preload(PassOwnPtr<PreloadRequest> preload, const Ne
request.setForPreload(true);
Resource* resource = m_document->loader()->startPreload(preload->resourceType(), request);
if (resource && preload->resourceType() == Resource::CSSStyleSheet && RuntimeEnabledFeatures::cssPreloadImportEnabled()) {
- OwnPtr<CSSPreloaderResourceClient> client = adoptPtr(new CSSPreloaderResourceClient(resource, this));
- resource->addClient(client.get());
- m_cssPreloaders.add(client.release());
+ m_cssPreloaders.append(new CSSPreloaderResourceClient(resource, this));
}
}

Powered by Google App Engine
This is Rietveld 408576698