third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp - Issue 1937033002: Fix crash in CSSStyleSheetResource::appendData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

Issue 1937033002: Fix crash in CSSStyleSheetResource::appendData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move CSSPreloaderResourceClient to the Oilpan heap, make it a ResourceOwner Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

index 78ebcd9928613cb4efdb798cef7753d0910e510b..348980a2d0701e9185888de057fe1cbc42f75c19 100644

--- a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

@@ -105,8 +105,10 @@ void CSSStyleSheetResource::appendData(const char* data, size_t length)

if (m_didNotifyFirstData)

return;

ResourceClientWalker<StyleSheetResourceClient> w(m_clients);

- while (StyleSheetResourceClient* c = w.next())

+ while (StyleSheetResourceClient* c = w.next()) {

+ ASSERT(m_data);

c->didAppendFirstData(this);

+ }

m_didNotifyFirstData = true;

}