Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1936963002: Restored the MirrorsUsed which was removed in CL 1933283002. (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restored the MirrorsUsed which was removed in CL 1933283002. The `git cl land` on https://codereview.chromium.org/1915123008 seemed to give rise to many timeout failures in the dart2js-jsshell columns of the build bot; that CL was then reverted. However, it turns out to be the removal of `@MirrorsUsed(metaTargets: 'ReflectiveTest')` in https://codereview.chromium.org/1933283002 that causes the timeouts (e.g., it changes an 11sec test run into a 64s test run, which violates the timeout constraint of 60s on the bot). BUG= Committed: https://github.com/dart-lang/sdk/commit/21a1345fa8df19676b69e9d6fc4978d0c1a5ffc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer/test/reflective_tests.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
TBR: Restores the `MirrorsUsed` which was removed in CL 1933283002, because that caused many tests ...
4 years, 7 months ago (2016-05-02 08:42:29 UTC) #2
eernst
Committed patchset #1 (id:1) manually as 21a1345fa8df19676b69e9d6fc4978d0c1a5ffc5 (presubmit successful).
4 years, 7 months ago (2016-05-02 08:42:55 UTC) #4
scheglov
4 years, 7 months ago (2016-05-02 13:51:51 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698