Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1933283002: Add @assertFailingTest annotation support. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M pkg/analyzer/test/reflective_tests.dart View 5 chunks +39 lines, -6 lines 2 comments Download

Messages

Total messages: 7 (1 generated)
scheglov
4 years, 7 months ago (2016-04-29 16:17:30 UTC) #1
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-04-29 16:31:51 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/1933283002/diff/1/pkg/analyzer/test/reflective_tests.dart File pkg/analyzer/test/reflective_tests.dart (right): https://codereview.chromium.org/1933283002/diff/1/pkg/analyzer/test/reflective_tests.dart#newcode32 pkg/analyzer/test/reflective_tests.dart:32: * Is `true` the application runs in the ...
4 years, 7 months ago (2016-04-29 17:57:31 UTC) #3
scheglov
https://codereview.chromium.org/1933283002/diff/1/pkg/analyzer/test/reflective_tests.dart File pkg/analyzer/test/reflective_tests.dart (right): https://codereview.chromium.org/1933283002/diff/1/pkg/analyzer/test/reflective_tests.dart#newcode32 pkg/analyzer/test/reflective_tests.dart:32: * Is `true` the application runs in the checked ...
4 years, 7 months ago (2016-04-29 18:04:07 UTC) #4
scheglov
Committed patchset #1 (id:1) manually as e9109cd05f45194dce20e524bf35f7c4ccb25677 (presubmit successful).
4 years, 7 months ago (2016-04-29 18:04:24 UTC) #6
eernst
4 years, 7 months ago (2016-05-02 09:11:43 UTC) #7
Message was sent while issue was closed.
On 2016/04/29 18:04:24, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> e9109cd05f45194dce20e524bf35f7c4ccb25677 (presubmit successful).

Hello Konstantin,

I reverted the removal of the `MirrorsUsed` annotation because my
CL got blamed for failures on dart2js-jsshell, but my experiments
show that it is this removal that makes the difference. I guess that
you would want to keep it (because tests run for 5-6 times longer in
the dart2js-jsshell columns without it), or alternatively you'd want
to mark a lot of tests as `slow` in the relevant status files.

I realize that there may be a need to add `_FailingTest` and 
`_AssertFailingTest` to the `MirrorsUsed` annotation, but I wanted to
make the smallest possible change that would still allow me to land
CL 1915123008 in good shape, so I just reinserted the old
`MirrorsUsed`, such that those timeouts go away.

Powered by Google App Engine
This is Rietveld 408576698