Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1936953004: S390: Fix storing to below stack to avoid sampler handler corrupting stored value (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix storing to below stack to avoid sampler handler corrupting stored value R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/141bc11e131e6d9fcffb4a30ca0ed2ea92d22e6f Cr-Commit-Position: refs/heads/master@{#35953}

Patch Set 1 #

Patch Set 2 : remove insertdoublehigh/low #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -67 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 3 chunks +20 lines, -26 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/s390/assembler-s390.cc View 5 chunks +5 lines, -2 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 5 chunks +5 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936953004/20001
4 years, 7 months ago (2016-05-02 21:12:51 UTC) #2
MTBrandyberry
lgtm
4 years, 7 months ago (2016-05-02 21:32:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 21:33:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936953004/20001
4 years, 7 months ago (2016-05-02 21:58:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 21:59:50 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 22:02:29 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/141bc11e131e6d9fcffb4a30ca0ed2ea92d22e6f
Cr-Commit-Position: refs/heads/master@{#35953}

Powered by Google App Engine
This is Rietveld 408576698