src/s390/code-stubs-s390.cc - Issue 1936953004: S390: Fix storing to below stack to avoid sampler handler corrupting stored value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/s390/code-stubs-s390.cc

Issue 1936953004: S390: Fix storing to below stack to avoid sampler handler corrupting stored value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove insertdoublehigh/low Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/s390/code-stubs-s390.cc

diff --git a/src/s390/code-stubs-s390.cc b/src/s390/code-stubs-s390.cc

index 488ac9d639ac411e78f8c649a80ee57f8019d854..1ae7facbf3921da01b6a5b87f917090642c4e0f4 100644

--- a/src/s390/code-stubs-s390.cc

+++ b/src/s390/code-stubs-s390.cc

@@ -4260,10 +4260,9 @@ void ProfileEntryHookStub::Generate(MacroAssembler* masm) {

// zLinux ABI requires caller's frame to have sufficient space for callee

// preserved regsiter save area.

__ LoadImmP(r0, Operand::Zero());

- __ StoreP(r0, MemOperand(sp, -kCalleeRegisterSaveAreaSize -

- kNumRequiredStackFrameSlots * kPointerSize));

__ lay(sp, MemOperand(sp, -kCalleeRegisterSaveAreaSize -

kNumRequiredStackFrameSlots * kPointerSize));

+ __ StoreP(r0, MemOperand(sp));

#if defined(USE_SIMULATOR)

// Under the simulator we need to indirect the entry hook through a

// trampoline function at a known address.

« no previous file with comments | « src/s390/assembler-s390.cc ('k') | src/s390/macro-assembler-s390.h » ('j') | no next file with comments »