mus: Don't activate non-activatable widgets on Show()

mus: Don't activate non-activatable widgets on Show()

This was preventing the shelf overflow bubble from opening. See bug for
details.

Make NativeWidgetMus::Show() behave similarly to NativeWidgetAura and check
WidgetDelegate::CanActivate() before activating the widget.

BUG=595851
TEST=added to views_mus_unittest

Committed: https://crrev.com/b69da6a7e57248527c6ec7fea8a5044f6ebc804d
Cr-Commit-Position: refs/heads/master@{#391303}

[James Cook, 2016-04-30 01:02:02]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-04-30 01:02:02]

msw, please take a look

After I wrote it I noticed that the test I added is basically equivalent to
WidgetInteractiveTest.CanActivateFlagIsHonored. However, we don't run
widget_interactive_uitests.cc on mus yet. I've tried twice to get it to run and
haven't gotten it working yet -- see crbug.com/602036 -- so I think having this
test is worth something in the short term.

[msw, 2016-04-30 02:16:29]

lgtm

[James Cook, 2016-04-30 19:44:32]

sky, can I get OWNERS for ui/views/mus ?

[James Cook, 2016-05-03 15:18:45]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-05-03 15:18:45]

sky, can I get OWNERS for ui/views/mus ?

Copy of comment 1 to msw:
After I wrote it I noticed that the test I added is basically equivalent to
WidgetInteractiveTest.CanActivateFlagIsHonored. However, we don't run
widget_interactive_uitests.cc on mus yet. I've tried twice to get it to run and
haven't gotten it working yet -- see crbug.com/602036 -- so I think having this
test is worth something in the short term.

[sky, 2016-05-03 16:42:50]

LGTM

[James Cook, 2016-05-03 17:30:52]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-05-03 17:30:52]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1936823002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-03 17:31:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936823002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936823002/40001

[commit-bot: I haz the power, 2016-05-03 18:23:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 18:24:31]

Description was changed from

==========
mus: Don't activate non-activatable widgets on Show()

This was preventing the shelf overflow bubble from opening. See bug for
details.

Make NativeWidgetMus::Show() behave similarly to NativeWidgetAura and check
WidgetDelegate::CanActivate() before activating the widget.

BUG=595851
TEST=added to views_mus_unittest
==========

to

==========
mus: Don't activate non-activatable widgets on Show()

This was preventing the shelf overflow bubble from opening. See bug for
details.

Make NativeWidgetMus::Show() behave similarly to NativeWidgetAura and check
WidgetDelegate::CanActivate() before activating the widget.

BUG=595851
TEST=added to views_mus_unittest

Committed: https://crrev.com/b69da6a7e57248527c6ec7fea8a5044f6ebc804d
Cr-Commit-Position: refs/heads/master@{#391303}
==========

[commit-bot: I haz the power, 2016-05-03 18:24:37]

Patchset 3 (id:??) landed as
https://crrev.com/b69da6a7e57248527c6ec7fea8a5044f6ebc804d
Cr-Commit-Position: refs/heads/master@{#391303}