Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: ui/views/mus/native_widget_mus_unittest.cc

Issue 1936823002: mus: Don't activate non-activatable widgets on Show() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/mus/native_widget_mus.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/mus/native_widget_mus_unittest.cc
diff --git a/ui/views/mus/native_widget_mus_unittest.cc b/ui/views/mus/native_widget_mus_unittest.cc
index e987d2cc29162123d09677ff91b013103dd92b9c..0ed22b8ee57c8399589b14f008c57ec280086237 100644
--- a/ui/views/mus/native_widget_mus_unittest.cc
+++ b/ui/views/mus/native_widget_mus_unittest.cc
@@ -132,6 +132,26 @@ TEST_F(NativeWidgetMusTest, OnActivationChanged) {
WidgetFocusManager::GetInstance()->RemoveFocusChangeListener(&focus_listener);
}
+// Tests that showing a non-activatable widget does not activate it.
+// TODO(jamescook): Remove this test when widget_interactive_uittests.cc runs
+// under mus.
+TEST_F(NativeWidgetMusTest, ShowNonActivatableWidget) {
+ Widget widget;
+ WidgetActivationObserver activation_observer(&widget);
+ Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_BUBBLE);
+ params.activatable = Widget::InitParams::ACTIVATABLE_NO;
+ params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+ params.bounds = gfx::Rect(10, 20, 100, 200);
+ widget.Init(params);
+ widget.Show();
+
+ // The widget is not currently active.
+ EXPECT_FALSE(widget.IsActive());
+
+ // The widget was never active.
+ EXPECT_EQ(0u, activation_observer.changes().size());
+}
+
// Tests that a window with an icon sets the mus::Window icon property.
TEST_F(NativeWidgetMusTest, AppIcon) {
// Create a Widget with a bitmap as the icon.
« no previous file with comments | « ui/views/mus/native_widget_mus.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698