Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2659)

Issue 19367002: Implement DeferredAnimatableValue (Closed)

Created:
7 years, 5 months ago by alancutter (OOO until 2018)
Modified:
7 years, 4 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), mithro-old, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, Eric Willigers
Visibility:
Public.

Description

Implement DeferredAnimatableValue This sentinal AnimatableValue marks points in a KeyframeVector that need to be replaced with a snapshot of the element's current computed CSSValue once such values have been applied during applyMatchedProperties(). BUG=232273 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154872

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 1

Patch Set 3 : Rename class #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M Source/core/animation/AnimatableValue.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/animation/AnimatableValue.cpp View 1 2 2 chunks +7 lines, -0 lines 1 comment Download
A + Source/core/animation/DeferredAnimatableValue.h View 1 2 2 chunks +16 lines, -10 lines 1 comment Download
M Source/core/core.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
alancutter (OOO until 2018)
7 years, 5 months ago (2013-07-16 12:13:52 UTC) #1
alancutter (OOO until 2018)
On 2013/07/16 12:13:52, alancutter wrote: ping
7 years, 5 months ago (2013-07-23 08:09:03 UTC) #2
pdr.
LGTM with a naming question and a code question. Is the name DeferredSnapshot spec'ed? I ...
7 years, 5 months ago (2013-07-23 22:45:08 UTC) #3
alancutter (OOO until 2018)
On 2013/07/23 22:45:08, pdr wrote: > LGTM with a naming question and a code question. ...
7 years, 5 months ago (2013-07-24 00:57:19 UTC) #4
pdr.
> https://codereview.chromium.org/19367002/diff/4001/Source/core/animation/AnimatableValue.cpp#newcode60 > > Source/core/animation/AnimatableValue.cpp:60: static > AnimatableDeferredSnapshot* > > deferredSnapshotSentinelValue = > AnimatableDeferredSnapshot::create().leakRef(); > ...
7 years, 5 months ago (2013-07-24 05:02:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/19367002/12001
7 years, 5 months ago (2013-07-24 06:16:56 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14441
7 years, 5 months ago (2013-07-24 08:15:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/19367002/12001
7 years, 5 months ago (2013-07-24 10:04:54 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14486
7 years, 5 months ago (2013-07-24 12:09:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/19367002/12001
7 years, 5 months ago (2013-07-24 23:44:32 UTC) #10
commit-bot: I haz the power
Change committed as 154872
7 years, 5 months ago (2013-07-25 00:34:57 UTC) #11
Steve Block
Is there a patch in progress to actually apply these deferred values? Also a couple ...
7 years, 4 months ago (2013-08-05 08:14:56 UTC) #12
alancutter (OOO until 2018)
7 years, 4 months ago (2013-08-05 10:00:28 UTC) #13
Message was sent while issue was closed.
On 2013/08/05 08:14:56, Steve Block wrote:
> Is there a patch in progress to actually apply these deferred values?

timloh is about to submit a patch to remove it actually. Turns out it's not
necessary anymore as we take the snapshot outside of the style resolving stage.

Powered by Google App Engine
This is Rietveld 408576698