Implement DeferredAnimatableValue

Source/core/animation/DeferredAnimatableValue.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef AnimatableNeutral_h
-#define AnimatableNeutral_h
+#ifndef DeferredAnimatableValue_h
+#define DeferredAnimatableValue_h
 
 #include "core/animation/AnimatableValue.h"
 
 namespace WebCore {
 
-class AnimatableNeutral : public AnimatableValue {
+// Used as a sentinal value to indicate where a snapshot of an element's CSS value should go in a KeyframeAnimationEffect::KeyframeVector.
+class DeferredAnimatableValue : public AnimatableValue {

[Steve Block, 2013/08/05 08:14:56]

For the neutral value you use the name 'AnimatableNeutral'. It would be good to
use a consistent pattern (I think I prefer the pattern here, so
AnimatableNeutral -> NeutralAnimatableValue)

 public:
-    virtual ~AnimatableNeutral() { }
+    virtual ~DeferredAnimatableValue() { }
 
     virtual PassRefPtr<CSSValue> toCSSValue() const OVERRIDE
     {
         ASSERT_NOT_REACHED();
         return 0;
     }
 
-    virtual bool isNeutral() const OVERRIDE { return true; }
+    virtual bool isDeferredSnapshot() const OVERRIDE { return true; }
 
 protected:
-    static PassRefPtr<AnimatableNeutral> create() { return adoptRef(new AnimatableNeutral()); }
+    static PassRefPtr<DeferredAnimatableValue> create() { return adoptRef(new DeferredAnimatableValue()); }
 
-    virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue* value, double fraction) const OVERRIDE
+    virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*, double fraction) const OVERRIDE
     {
         ASSERT_NOT_REACHED();
         return 0;
     }
 
-    virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue* value) const OVERRIDE { return defaultAddWith(this, value); }
+    virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue*) const OVERRIDE
+    {
+        ASSERT_NOT_REACHED();
+        return 0;
+    }
 
 private:
-    AnimatableNeutral() : AnimatableValue(TypeNeutral) { }
+    DeferredAnimatableValue() : AnimatableValue(TypeDeferred) { }
 
     friend class AnimatableValue;
 };
 
+
 } // namespace WebCore
 
-#endif // AnimatableNeutral_h
+#endif // DeferredAnimatableValue_h