Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1936693002: Revert "Workaround #537" (Closed)

Created:
4 years, 7 months ago by vsm
Modified:
4 years, 7 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Workaround #537" Undoing this. Paul fixed this in 1.17. We'll need to run with 1.17 builds going forward, but we need that for other reasons. Fixes #537 R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/21ba725bb737684bae8e809c9ae9fff53c55fbad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M lib/runtime/dart_sdk.js View 2 chunks +3 lines, -3 lines 0 comments Download
M tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
vsm
4 years, 7 months ago (2016-05-03 17:29:43 UTC) #5
vsm
4 years, 7 months ago (2016-05-03 17:31:06 UTC) #6
Jacob
lgtm
4 years, 7 months ago (2016-05-03 17:38:32 UTC) #7
vsm
4 years, 7 months ago (2016-05-03 17:39:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21ba725bb737684bae8e809c9ae9fff53c55fbad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698