tool/input_sdk/lib/js/dart2js/js_dart2js.dart - Issue 1936693002: Revert "Workaround #537"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/lib/js/dart2js/js_dart2js.dart

Issue 1936693002: Revert "Workaround #537" (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/lib/js/dart2js/js_dart2js.dart

diff --git a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart

index f9f18e09e56237d1842b15ac7006b936729218a2..4169bed09284d98d15d9616f6f3033bfa6dd444d 100644

--- a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart

+++ b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart

@@ -317,8 +317,7 @@ class JsArray<E> extends JsObject with ListMixin<E> {

/**

* Creates a new JavaScript array.

- // TODO(vsm): Making this a factory to workaround #537.

- factory JsArray() { return new JsArray._fromJs([]); }

+ JsArray() : super._fromJs([]);

/**

* Creates a new JavaScript array and initializes it to the contents of

« no previous file with comments | « lib/runtime/dart_sdk.js ('k') | no next file » | no next file with comments »