Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1936653002: Add reminders that these classes have constexpr default constructors. (Closed)

Created:
4 years, 7 months ago by mtklein_C
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add reminders that these classes have constexpr default constructors. We can do this now that we can write "constexpr". GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1936653002 Committed: https://skia.googlesource.com/skia/+/e86e51fe7e69ae85ba52de71d19ad62f7bb87ef8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M include/private/SkOnce.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/private/SkSpinlock.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936653002/1
4 years, 7 months ago (2016-04-29 20:12:11 UTC) #3
mtklein_C
4 years, 7 months ago (2016-04-29 20:24:01 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 20:24:37 UTC) #7
bungeman-skia
lgtm
4 years, 7 months ago (2016-04-29 20:56:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936653002/1
4 years, 7 months ago (2016-04-29 20:56:50 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 20:58:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e86e51fe7e69ae85ba52de71d19ad62f7bb87ef8

Powered by Google App Engine
This is Rietveld 408576698