include/private/SkOnce.h - Issue 1936653002: Add reminders that these classes have constexpr default constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/private/SkOnce.h

Issue 1936653002: Add reminders that these classes have constexpr default constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/private/SkOnce.h

diff --git a/include/private/SkOnce.h b/include/private/SkOnce.h

index 1c68fb7da1396771aa3bed37365b321111270dde..507dcb5b8cf14dfdbecef9e9da81e7eea0e90a51 100644

--- a/include/private/SkOnce.h

+++ b/include/private/SkOnce.h

@@ -19,6 +19,8 @@

class SkOnce {

public:

+ constexpr SkOnce() = default;

template <typename Fn, typename... Args>

void operator()(Fn&& fn, Args&&... args) {

auto state = fState.load(std::memory_order_acquire);

« no previous file with comments | « no previous file | include/private/SkSpinlock.h » ('j') | no next file with comments »