Memory Infra: Replace memory_health_plan with top_10_mobile

Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
Committed: https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a
Cr-Commit-Position: refs/heads/master@{#395876}

[perezju, 2016-04-29 12:52:58]

Description was changed from

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

Also deprecates the (short-lived) memory.memory_health_quick.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
==========

to

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

Also deprecates the (short-lived) memory.memory_health_quick.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[perezju, 2016-04-29 12:58:06]

perezju@chromium.org changed reviewers:
+ petrcermak@chromium.org, primiano@google.com, sullivan@chromium.org

[perezju, 2016-04-29 12:58:06]

Getting this CL ready to review. However should not be landed until:

- https://codereview.chromium.org/1936493002/ has also landed
- old data for memory.top_10_mobile has been removed from dashboards.

https://codereview.chromium.org/1936533002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (left):

https://codereview.chromium.org/1936533002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:133: # Disabled on reference builds
because they don't support the new
Ignore this bit, this should happen at
https://codereview.chromium.org/1936493002/

https://codereview.chromium.org/1936533002/diff/1/tools/perf/page_sets/memory...
File tools/perf/page_sets/memory_top_10_mobile.py (right):

https://codereview.chromium.org/1936533002/diff/1/tools/perf/page_sets/memory...
tools/perf/page_sets/memory_top_10_mobile.py:36: return  # Tracing is not
running, e.g., when recording a WPR archive.
This allows to wpr recordings directly on the benchmark (I used some hacked
page-set before to do the original recording.)

[perezju, 2016-04-29 13:03:32]

Description was changed from

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

Also deprecates the (short-lived) memory.memory_health_quick.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

Also deprecates the (short-lived) memory.memory_health_quick.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[perezju, 2016-04-29 13:03:32]

perezju@chromium.org changed reviewers:
+ primiano@chromium.org
- primiano@google.com

[sullivan, 2016-04-29 13:31:44]

lgtm

https://codereview.chromium.org/1936533002/diff/1/tools/perf/page_sets/memory...
File tools/perf/page_sets/memory_top_10_mobile.py (right):

https://codereview.chromium.org/1936533002/diff/1/tools/perf/page_sets/memory...
tools/perf/page_sets/memory_top_10_mobile.py:36: return  # Tracing is not
running, e.g., when recording a WPR archive.
On 2016/04/29 12:58:06, perezju wrote:
> This allows to wpr recordings directly on the benchmark (I used some hacked
> page-set before to do the original recording.)

Should there be some log warning/error here? IIUC, this line should never be hit
on the perfbots, right?

[perezju, 2016-05-24 13:51:20]

Description was changed from

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

Also deprecates the (short-lived) memory.memory_health_quick.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[perezju, 2016-05-24 14:03:42]

As discussed today, this switches the page set of the old
memory.memory_health_plan benchmark and renames it to memory.top_10_mobile.

And now is a good time to land since we've just passed a branch point and
metrics look stable.

https://codereview.chromium.org/1936533002/diff/1/tools/perf/page_sets/memory...
File tools/perf/page_sets/memory_top_10_mobile.py (right):

https://codereview.chromium.org/1936533002/diff/1/tools/perf/page_sets/memory...
tools/perf/page_sets/memory_top_10_mobile.py:36: return  # Tracing is not
running, e.g., when recording a WPR archive.
On 2016/04/29 13:31:44, sullivan wrote:
> On 2016/04/29 12:58:06, perezju wrote:
> > This allows to wpr recordings directly on the benchmark (I used some hacked
> > page-set before to do the original recording.)
> 
> Should there be some log warning/error here? IIUC, this line should never be
hit
> on the perfbots, right?

Done. Added a warning message.

[sullivan, 2016-05-24 14:34:02]

lgtm

[petrcermak, 2016-05-24 15:08:56]

LGTM with 2 nits.

Thanks,
Petr

https://codereview.chromium.org/1936533002/diff/40001/tools/perf/benchmarks/m...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/1936533002/diff/40001/tools/perf/benchmarks/m...
tools/perf/benchmarks/memory_infra.py:57: # TODO(bashi): Workaround for
http://crbug.com/532075
nit: Missing period (also applies to line 80).

https://codereview.chromium.org/1936533002/diff/40001/tools/perf/page_sets/me...
File tools/perf/page_sets/memory_top_10_mobile.py (right):

https://codereview.chromium.org/1936533002/diff/40001/tools/perf/page_sets/me...
tools/perf/page_sets/memory_top_10_mobile.py:21: class
MemoryMeasuringPage(page_module.Page):
nit: I'd rename this to "MemoryMeasurementPage".

[perezju, 2016-05-24 15:33:48]

https://codereview.chromium.org/1936533002/diff/40001/tools/perf/benchmarks/m...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/1936533002/diff/40001/tools/perf/benchmarks/m...
tools/perf/benchmarks/memory_infra.py:57: # TODO(bashi): Workaround for
http://crbug.com/532075
On 2016/05/24 15:08:55, petrcermak wrote:
> nit: Missing period (also applies to line 80).

Punctuation at the end of URLs always makes me feel uneasy, ... but there it
goes.

https://codereview.chromium.org/1936533002/diff/40001/tools/perf/page_sets/me...
File tools/perf/page_sets/memory_top_10_mobile.py (right):

https://codereview.chromium.org/1936533002/diff/40001/tools/perf/page_sets/me...
tools/perf/page_sets/memory_top_10_mobile.py:21: class
MemoryMeasuringPage(page_module.Page):
On 2016/05/24 15:08:55, petrcermak wrote:
> nit: I'd rename this to "MemoryMeasurementPage".

Done.

[Primiano Tucci (use gerrit), 2016-05-25 09:52:06]

LGTM

[perezju, 2016-05-25 09:52:51]

The CQ bit was checked by perezju@chromium.org

[perezju, 2016-05-25 09:52:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/1936533002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-25 09:53:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936533002/80001

[commit-bot: I haz the power, 2016-05-25 13:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 13:09:26]

Try jobs failed on following builders:
  linux_perf_cq on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/bu...)

[perezju, 2016-05-25 13:19:57]

Description was changed from

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
==========

[perezju, 2016-05-25 13:20:15]

Removing CQ try bots

[perezju, 2016-05-25 13:20:23]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2016-05-25 13:20:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936533002/80001

[commit-bot: I haz the power, 2016-05-25 13:24:34]

Description was changed from

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
==========

to

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
==========

[commit-bot: I haz the power, 2016-05-25 13:24:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-25 13:25:35]

Description was changed from

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361
==========

to

==========
Memory Infra: Replace memory_health_plan with top_10_mobile

Replace memory.memory_health_plan with the memory.top_10_mobile
benchmark.

This keeps the story to provide foreground/background measurements,
but swaps the page set to use top_10_mobile.

New recordings are provided.

Perf sheriffs warning: this is very likely to cause measurements in
memory.top_10_mobile to shift.

BUG=606361

Committed: https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a
Cr-Commit-Position: refs/heads/master@{#395876}
==========

[commit-bot: I haz the power, 2016-05-25 13:25:41]

Patchset 5 (id:??) landed as
https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a
Cr-Commit-Position: refs/heads/master@{#395876}

[michaelbai, 2016-05-25 20:37:05]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2007113009/ by michaelbai@chromium.org.

The reason for reverting is: It seemed this broke the downstream bots

https://uberchromegw.corp.google.com/i/internal.client.clank/builders/health-...

.