Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: tools/perf/benchmarks/memory_infra.py

Issue 1936533002: Memory Infra: Replace memory_health_plan with top_10_mobile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: warn when tracing is off Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 8
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import tracing_category_filter 10 from telemetry.timeline import tracing_category_filter
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 )) 47 ))
48 elif self.TBM_VERSION == 2: 48 elif self.TBM_VERSION == 2:
49 # TBMv2 (see tracing/tracing/metrics/system_health/memory_metric.html 49 # TBMv2 (see tracing/tracing/metrics/system_health/memory_metric.html
50 # in third_party/catapult). 50 # in third_party/catapult).
51 tbm_options.SetTimelineBasedMetric('memoryMetric') 51 tbm_options.SetTimelineBasedMetric('memoryMetric')
52 else: 52 else:
53 raise Exception('Unrecognized TBM version: %s' % self.TBM_VERSION) 53 raise Exception('Unrecognized TBM version: %s' % self.TBM_VERSION)
54 return tbm_options 54 return tbm_options
55 55
56 56
57 # TODO(crbug.com/606361): Remove benchmark when replaced by the TBMv2 version. 57 # TODO(bashi): Workaround for http://crbug.com/532075
petrcermak 2016/05/24 15:08:55 nit: Missing period (also applies to line 80).
perezju 2016/05/24 15:33:48 Punctuation at the end of URLs always makes me fee
58 @benchmark.Disabled('all') 58 # @benchmark.Enabled('android') shouldn't be needed.
59 class MemoryHealthPlan(_MemoryInfra): 59 @benchmark.Enabled('android')
60 """Timeline based benchmark for the Memory Health Plan.""" 60 class MemoryBenchmarkTop10Mobile(_MemoryInfra):
61 page_set = page_sets.MemoryHealthStory 61 """Measure foreground/background memory on top 10 mobile page set.
62
63 This metric provides memory measurements for the System Health Plan of
64 Chrome on Android.
65 """
66 page_set = page_sets.MemoryTop10Mobile
62 options = {'pageset_repeat': 5} 67 options = {'pageset_repeat': 5}
63 68
64 @classmethod 69 @classmethod
65 def Name(cls): 70 def Name(cls):
66 return 'memory.memory_health_plan' 71 return 'memory.top_10_mobile'
67 72
68 @classmethod 73 @classmethod
69 def ShouldDisable(cls, possible_browser): 74 def ShouldDisable(cls, possible_browser):
70 # TODO(crbug.com/586148): Benchmark should not depend on DeskClock app. 75 # TODO(crbug.com/586148): Benchmark should not depend on DeskClock app.
71 return not possible_browser.platform.CanLaunchApplication( 76 return not possible_browser.platform.CanLaunchApplication(
72 'com.google.android.deskclock') 77 'com.google.android.deskclock')
73 78
74 79
80 # TODO(bashi): Workaround for http://crbug.com/532075
81 # @benchmark.Enabled('android') shouldn't be needed.
75 @benchmark.Enabled('android') 82 @benchmark.Enabled('android')
76 class TBMv2MemoryBenchmarkTop10Mobile(MemoryHealthPlan): 83 class TBMv2MemoryBenchmarkTop10Mobile(MemoryBenchmarkTop10Mobile):
77 """Timeline based benchmark for the Memory Health Plan based on TBMv2. 84 """Measure foreground/background memory on top 10 mobile page set (TBMv2).
78 85
79 This is a temporary benchmark to compare the new TBMv2 memory metric 86 This is a temporary benchmark to compare the new TBMv2 memory metric
80 (memory_metric.html) with the existing TBMv1 one (memory_timeline.py). Once 87 (memory_metric.html) with the existing TBMv1 one (memory_timeline.py). Once
81 all issues associated with the TBMv2 metric are resolved, all memory 88 all issues associated with the TBMv2 metric are resolved, all memory
82 benchmarks (including the ones in this file) will switch to use it instead 89 benchmarks (including the ones in this file) will switch to use it instead
83 of the TBMv1 metric and this temporary benchmark will be removed. See 90 of the TBMv1 metric and this temporary benchmark will be removed. See
84 crbug.com/60361. 91 crbug.com/60361.
85 """ 92 """
86 TBM_VERSION = 2 93 TBM_VERSION = 2
87 94
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 172
166 @benchmark.Disabled('android-webview') # http://crbug.com/612210 173 @benchmark.Disabled('android-webview') # http://crbug.com/612210
167 class MemoryLongRunningIdleGmailBackground(_MemoryV8Benchmark): 174 class MemoryLongRunningIdleGmailBackground(_MemoryV8Benchmark):
168 """Use (recorded) real world web sites and measure memory consumption 175 """Use (recorded) real world web sites and measure memory consumption
169 of long running idle Gmail page """ 176 of long running idle Gmail page """
170 page_set = page_sets.LongRunningIdleGmailBackgroundPageSet 177 page_set = page_sets.LongRunningIdleGmailBackgroundPageSet
171 178
172 @classmethod 179 @classmethod
173 def Name(cls): 180 def Name(cls):
174 return 'memory.long_running_idle_gmail_background_tbmv2' 181 return 'memory.long_running_idle_gmail_background_tbmv2'
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/data/memory_health_plan.json » ('j') | tools/perf/page_sets/memory_top_10_mobile.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698