Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1936313002: Reland of Allow overriding GN build flags (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Reland of Allow overriding GN build flags This reverts commit 038bf0b129e56212a6de0989dca1ae023bb17c5d. In order to enable XFA from GN builds we need to be able to override pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created in Chrome. To use that, //pdfium.gni reads the override values and sets them into the defined arguments. We have to create a build_overrides/pdfium.gni file in PDFium that sets the default overrides for PDFium builds. BUG=chromium:62400 Committed: https://pdfium.googlesource.com/pdfium/+/fd670fdef8984fd7f8824b17d8fcf52fdec9aacc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
A build_overrides/pdfium.gni View 1 chunk +14 lines, -0 lines 0 comments Download
M pdfium.gni View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL. I think this is closer to what the mac overrides are doing? (The Chrome ...
4 years, 7 months ago (2016-05-02 18:44:54 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-02 23:58:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936313002/1
4 years, 7 months ago (2016-05-03 13:13:58 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 13:14:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/fd670fdef8984fd7f8824b17d8fcf52fdec9...

Powered by Google App Engine
This is Rietveld 408576698