Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1936103002: Remove unused encodedString API on SkWriteBuffer/SkReadBuffer (Closed)

Created:
4 years, 7 months ago by Brian Osman
Modified:
4 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M include/core/SkWriteBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/core/SkValidatingReadBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/core/SkWriteBuffer.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936103002/1
4 years, 7 months ago (2016-05-02 13:54:04 UTC) #3
Brian Osman
Doing some cleanup prompted by reed@'s review in separate smaller CLs.
4 years, 7 months ago (2016-05-02 13:54:38 UTC) #5
reed1
auto lgtm for CL with only deletes
4 years, 7 months ago (2016-05-02 13:55:35 UTC) #6
mtklein
lgtm
4 years, 7 months ago (2016-05-02 13:55:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936103002/1
4 years, 7 months ago (2016-05-02 14:04:59 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 14:09:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/57b46159740020ef904aaf41e9e5ae07106591cc

Powered by Google App Engine
This is Rietveld 408576698