AIX:Proposal to use kSemaphoreAlignmentMask instead kPointerAlignmentMask

AIX:Proposal to use kSemaphoreAlignmentMask instead kPointerAlignmentMask

native_handle_ on AIX64 is of type int, and therefore fails
on an operation with a pointer type. Use
kSemaphoreAlignmentMask as sizeof(int) on AIX and
sizeof(pointer) otherwise.

R=jochen@chromium.org, mbrandy@us.ibm.com

BUG=v8:4767
LOG=N

Committed: https://crrev.com/46b932f405836949c19b43670571aeb458ef5a62
Cr-Commit-Position: refs/heads/master@{#35988}

[JaideepBajwa, 2016-05-01 22:45:03]

Description was changed from

==========
AIX:Proposal to use kSemaphoreAlignmentMask instead kPointerAlignmentMask

native_handle_ on AIX64 is of type int, and therefore fails
on an operation with a pointer type. Use
kSemaphoreAlignmentMask as sizeof(int) on AIX and
sizeof(pointer) otherwise.

R=jochen@chromium.org, mbrandy@us.ibm.com

BUG=v8:4767
LOG=N
==========

to

==========
AIX:Proposal to use kSemaphoreAlignmentMask instead kPointerAlignmentMask

native_handle_ on AIX64 is of type int, and therefore fails
on an operation with a pointer type. Use
kSemaphoreAlignmentMask as sizeof(int) on AIX and
sizeof(pointer) otherwise.

R=jochen@chromium.org, mbrandy@us.ibm.com

BUG=v8:4767
LOG=N
==========

[JaideepBajwa, 2016-05-01 22:45:54]

PTAL

[jochen (gone - plz use gerrit), 2016-05-02 16:15:45]

https://codereview.chromium.org/1936003002/diff/1/src/base/platform/semaphore.h
File src/base/platform/semaphore.h (right):

https://codereview.chromium.org/1936003002/diff/1/src/base/platform/semaphore...
src/base/platform/semaphore.h:24: const uintptr_t kSemaphoreAlignmentMask =
sizeof(int) - 1;
Any reason this is defined in the header?

[JaideepBajwa, 2016-05-02 17:12:46]

On 2016/05/02 16:15:45, jochen wrote:
>
https://codereview.chromium.org/1936003002/diff/1/src/base/platform/semaphore.h
> File src/base/platform/semaphore.h (right):
> 
>
https://codereview.chromium.org/1936003002/diff/1/src/base/platform/semaphore...
> src/base/platform/semaphore.h:24: const uintptr_t kSemaphoreAlignmentMask =
> sizeof(int) - 1;
> Any reason this is defined in the header?
I added in the header in case its needed at other places. But I can move it to
cc.

[JaideepBajwa, 2016-05-02 22:26:50]

updated, PTAL

[jochen (gone - plz use gerrit), 2016-05-03 11:03:09]

lgtm with comment

https://codereview.chromium.org/1936003002/diff/20001/src/base/platform/semap...
File src/base/platform/semaphore.cc (right):

https://codereview.chromium.org/1936003002/diff/20001/src/base/platform/semap...
src/base/platform/semaphore.cc:83: const uintptr_t kPointerAlignmentMask =
sizeof(int) - 1;
please keep to rename of kPointerAlignmentMask to kSemaphoreAlignmentMask

[JaideepBajwa, 2016-05-03 13:58:44]

On 2016/05/03 11:03:09, jochen wrote:
> lgtm with comment
> 
>
https://codereview.chromium.org/1936003002/diff/20001/src/base/platform/semap...
> File src/base/platform/semaphore.cc (right):
> 
>
https://codereview.chromium.org/1936003002/diff/20001/src/base/platform/semap...
> src/base/platform/semaphore.cc:83: const uintptr_t kPointerAlignmentMask =
> sizeof(int) - 1;
> please keep to rename of kPointerAlignmentMask to kSemaphoreAlignmentMask

updated.

[JaideepBajwa, 2016-05-03 13:58:50]

The CQ bit was checked by bjaideep@ca.ibm.com

[JaideepBajwa, 2016-05-03 13:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1936003002/#ps40001
(title: "renamed kPointerAlignmentMask to kSemaphoreAlignmentMask")

[commit-bot: I haz the power, 2016-05-03 13:58:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936003002/40001

[commit-bot: I haz the power, 2016-05-03 14:24:27]

Description was changed from

==========
AIX:Proposal to use kSemaphoreAlignmentMask instead kPointerAlignmentMask

native_handle_ on AIX64 is of type int, and therefore fails
on an operation with a pointer type. Use
kSemaphoreAlignmentMask as sizeof(int) on AIX and
sizeof(pointer) otherwise.

R=jochen@chromium.org, mbrandy@us.ibm.com

BUG=v8:4767
LOG=N
==========

to

==========
AIX:Proposal to use kSemaphoreAlignmentMask instead kPointerAlignmentMask

native_handle_ on AIX64 is of type int, and therefore fails
on an operation with a pointer type. Use
kSemaphoreAlignmentMask as sizeof(int) on AIX and
sizeof(pointer) otherwise.

R=jochen@chromium.org, mbrandy@us.ibm.com

BUG=v8:4767
LOG=N
==========

[commit-bot: I haz the power, 2016-05-03 14:24:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 14:25:40]

Description was changed from

==========
AIX:Proposal to use kSemaphoreAlignmentMask instead kPointerAlignmentMask

native_handle_ on AIX64 is of type int, and therefore fails
on an operation with a pointer type. Use
kSemaphoreAlignmentMask as sizeof(int) on AIX and
sizeof(pointer) otherwise.

R=jochen@chromium.org, mbrandy@us.ibm.com

BUG=v8:4767
LOG=N
==========

to

==========
AIX:Proposal to use kSemaphoreAlignmentMask instead kPointerAlignmentMask

native_handle_ on AIX64 is of type int, and therefore fails
on an operation with a pointer type. Use
kSemaphoreAlignmentMask as sizeof(int) on AIX and
sizeof(pointer) otherwise.

R=jochen@chromium.org, mbrandy@us.ibm.com

BUG=v8:4767
LOG=N

Committed: https://crrev.com/46b932f405836949c19b43670571aeb458ef5a62
Cr-Commit-Position: refs/heads/master@{#35988}
==========

[commit-bot: I haz the power, 2016-05-03 14:25:42]

Patchset 3 (id:??) landed as
https://crrev.com/46b932f405836949c19b43670571aeb458ef5a62
Cr-Commit-Position: refs/heads/master@{#35988}