Create array of extension views without side effects

extensions/renderer/runtime_custom_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/runtime_custom_bindings.h"
 
 #include <stdint.h>
 
 #include <memory>
 
@@ skipping 139 matching lines @@
     return;
   }
 
   std::string extension_id = context()->GetExtensionID();
   if (extension_id.empty())
     return;
 
   std::vector<content::RenderFrame*> frames =
       ExtensionFrameHelper::GetExtensionFrames(extension_id, browser_window_id,
                                                view_type);
+  v8::Local<v8::Context> v8_context = args.GetIsolate()->GetCurrentContext();
   v8::Local<v8::Array> v8_views = v8::Array::New(args.GetIsolate());
   int v8_index = 0;
   for (content::RenderFrame* frame : frames) {
     // We filter out iframes here. GetExtensionViews should only return the
     // main views, not any subframes. (Returning subframes can cause broken
     // behavior by treating an app window's iframe as its main frame, and maybe
     // other nastiness).
     if (frame->GetWebFrame()->top() != frame->GetWebFrame())
       continue;
 
     v8::Local<v8::Context> context =
         frame->GetWebFrame()->mainWorldScriptContext();
     if (!context.IsEmpty()) {
       v8::Local<v8::Value> window = context->Global();
       DCHECK(!window.IsEmpty());
-      v8_views->Set(v8::Integer::New(args.GetIsolate(), v8_index++), window);
+      v8::Maybe<bool> maybe =
+        v8_views->CreateDataProperty(v8_context, v8_index++, window);
+      DCHECK(maybe.IsJust() && maybe.FromJust());
     }
   }
 
   args.GetReturnValue().Set(v8_views);
 }
 
 }  // namespace extensions